Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: minidump/minidump_crashpad_info_writer_test.cc

Issue 1000263003: Add MinidumpCrashpadInfo::report_id (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_crashpad_info_writer.cc ('k') | minidump/minidump_extensions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_crashpad_info_writer_test.cc
diff --git a/minidump/minidump_crashpad_info_writer_test.cc b/minidump/minidump_crashpad_info_writer_test.cc
index 994f0a8bb6a46e100f8eba1ce15c2ada558a5b5b..06733edba549a5a7358047041456c2a3b3efe019 100644
--- a/minidump/minidump_crashpad_info_writer_test.cc
+++ b/minidump/minidump_crashpad_info_writer_test.cc
@@ -80,15 +80,21 @@ TEST(MinidumpCrashpadInfoWriter, Empty) {
string_file.string(), &crashpad_info, &simple_annotations, &module_list));
EXPECT_EQ(MinidumpCrashpadInfo::kVersion, crashpad_info->version);
+ EXPECT_EQ(UUID(), crashpad_info->report_id);
EXPECT_EQ(UUID(), crashpad_info->client_id);
EXPECT_FALSE(simple_annotations);
EXPECT_FALSE(module_list);
}
-TEST(MinidumpCrashpadInfoWriter, ClientID) {
+TEST(MinidumpCrashpadInfoWriter, ReportAndClientID) {
MinidumpFileWriter minidump_file_writer;
auto crashpad_info_writer = make_scoped_ptr(new MinidumpCrashpadInfoWriter());
+ UUID report_id;
+ ASSERT_TRUE(
+ report_id.InitializeFromString("01234567-89ab-cdef-0123-456789abcdef"));
+ crashpad_info_writer->SetReportID(report_id);
+
UUID client_id;
ASSERT_TRUE(
client_id.InitializeFromString("00112233-4455-6677-8899-aabbccddeeff"));
@@ -109,6 +115,7 @@ TEST(MinidumpCrashpadInfoWriter, ClientID) {
string_file.string(), &crashpad_info, &simple_annotations, &module_list));
EXPECT_EQ(MinidumpCrashpadInfo::kVersion, crashpad_info->version);
+ EXPECT_EQ(report_id, crashpad_info->report_id);
EXPECT_EQ(client_id, crashpad_info->client_id);
EXPECT_FALSE(simple_annotations);
EXPECT_FALSE(module_list);
@@ -208,6 +215,10 @@ TEST(MinidumpCrashpadInfoWriter, CrashpadModuleList) {
}
TEST(MinidumpCrashpadInfoWriter, InitializeFromSnapshot) {
+ UUID report_id;
+ ASSERT_TRUE(
+ report_id.InitializeFromString("fedcba98-7654-3210-fedc-ba9876543210"));
+
UUID client_id;
ASSERT_TRUE(
client_id.InitializeFromString("fedcba98-7654-3210-0123-456789abcdef"));
@@ -230,6 +241,7 @@ TEST(MinidumpCrashpadInfoWriter, InitializeFromSnapshot) {
// Try again with a useful module.
process_snapshot.reset(new TestProcessSnapshot());
+ process_snapshot->SetReportID(report_id);
process_snapshot->SetClientID(client_id);
std::map<std::string, std::string> annotations_simple_map;
@@ -259,6 +271,7 @@ TEST(MinidumpCrashpadInfoWriter, InitializeFromSnapshot) {
EXPECT_EQ(MinidumpCrashpadInfo::kVersion, info->version);
+ EXPECT_EQ(report_id, info->report_id);
EXPECT_EQ(client_id, info->client_id);
ASSERT_TRUE(simple_annotations);
« no previous file with comments | « minidump/minidump_crashpad_info_writer.cc ('k') | minidump/minidump_extensions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698