Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: minidump/minidump_crashpad_info_writer.cc

Issue 1000263003: Add MinidumpCrashpadInfo::report_id (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_crashpad_info_writer.h ('k') | minidump/minidump_crashpad_info_writer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_crashpad_info_writer.cc
diff --git a/minidump/minidump_crashpad_info_writer.cc b/minidump/minidump_crashpad_info_writer.cc
index d8bdb0d36598450cd9071f949cedd842c547b5bc..9314224b7cd5f6b6d0eb2482686fe6c490d1c466 100644
--- a/minidump/minidump_crashpad_info_writer.cc
+++ b/minidump/minidump_crashpad_info_writer.cc
@@ -38,6 +38,10 @@ void MinidumpCrashpadInfoWriter::InitializeFromSnapshot(
DCHECK_EQ(state(), kStateMutable);
DCHECK(!module_list_);
+ UUID report_id;
+ process_snapshot->ReportID(&report_id);
+ SetReportID(report_id);
+
UUID client_id;
process_snapshot->ClientID(&client_id);
SetClientID(client_id);
@@ -58,6 +62,12 @@ void MinidumpCrashpadInfoWriter::InitializeFromSnapshot(
}
}
+void MinidumpCrashpadInfoWriter::SetReportID(const UUID& report_id) {
+ DCHECK_EQ(state(), kStateMutable);
+
+ crashpad_info_.report_id = report_id;
+}
+
void MinidumpCrashpadInfoWriter::SetClientID(const UUID& client_id) {
DCHECK_EQ(state(), kStateMutable);
@@ -128,7 +138,8 @@ MinidumpStreamType MinidumpCrashpadInfoWriter::StreamType() const {
}
bool MinidumpCrashpadInfoWriter::IsUseful() const {
- return crashpad_info_.client_id != UUID() ||
+ return crashpad_info_.report_id != UUID() ||
+ crashpad_info_.client_id != UUID() ||
simple_annotations_ ||
module_list_;
}
« no previous file with comments | « minidump/minidump_crashpad_info_writer.h ('k') | minidump/minidump_crashpad_info_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698