Issue 100023002: MIPS: Refactor BinaryOpIC to be able to use different stubs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100023002: MIPS: Refactor BinaryOpIC to be able to use different stubs. (Closed)

Created:
7 years ago by palfia

Modified:
7 years ago

Reviewers:
kisg, Paul Lind, danno, Benedikt Meurer, kilvadyb, dusmil

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Refactor BinaryOpIC to be able to use different stubs. Port r18191 (c20c6dc1) Original commit message: Previously BinaryOpIC and BinaryOpStub were pretty much interdependent. However, in order to use allocation sites for string adds on-demand, we need to be able to use different stubs (with a different number of register parameters, via trampolines) depending on the BinaryOpIC state. BUG= R=plind44@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=18213

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -7 lines)			Patch
M	src/mips/code-stubs-mips.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	4 chunks	+3 lines, -4 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r18213 (presubmit successful).

Expand Messages | Collapse Messages