Mouse hover out of context menu should un-select menu item....

Mouse hover out of context menu should un-select menu item.

All Context Menu's which are implemented with ChromeMenu is not properly un-selecting the menu item when out of focus. The areas where this is affected are: * Tabs * Bookmark bar * Bookmark managerThe others uses winapi for context menus. Doesn't use ChromeMenu, uses HMENU, that explanes why the others work.

For this fix, I had to make sure that the MenuPart is always NONE when the mouse is moved outside of the context menu regions, and that is always the case. Hence, we can assure to remove selection. The same way it has been done for SetSelection, I have used the same technique for this, but simpler.

BUG=8088
TEST=For the above mentioned affected areas, I brought up the context menu by right clicking, and hovered over a menu item, then move the mouse horizontally outside the context menu region, it deselected the item.

[Mohamed Mansour (USE mhm), 2009-04-26 13:50:39]

You guys touched the codebase a lot :) And my area has no blame, just
"initial.committers"

[sky, 2009-04-27 16:02:57]

There's some additional cleanup that should be done while you're doing this:

. any_menu_contains_mouse_ should be removed.
. you'll need similar logic in mouse dragged.

http://codereview.chromium.org/100022/diff/1/2
File chrome/views/controls/menu/chrome_menu.cc (right):

http://codereview.chromium.org/100022/diff/1/2#newcode1933
Line 1933: std::vector<MenuItemView*> path;
You shouldn't change the selection like this, it won't clean things up properly.
Use SetSelection instead.

[Mohamed Mansour (USE mhm), 2009-04-29 01:04:47]

Hey guys, this is my second approach, it seems to fix this issue.

[sky, 2009-04-29 16:29:28]

Don't you need to change dragging as well?

http://codereview.chromium.org/100022/diff/5/1004
File chrome/views/controls/menu/chrome_menu.h (right):

http://codereview.chromium.org/100022/diff/5/1004#newcode28
Line 28: // namespace {
Why are you commenting out the namespace here?

[Mohamed Mansour (USE mhm), 2009-05-01 03:32:18]

Hi sky, sorry for the late reply. I had major computer issues.

I really don't understand why we have the drag and drop for a Chrome menu. I
don't see that functionality within Chrome. Is that for future implementation?

This patch only fixes when you move the mouse outside the region. Any
suggestions on how to approach the dragging?

http://codereview.chromium.org/100022/diff/5/1004
File chrome/views/controls/menu/chrome_menu.h (right):

http://codereview.chromium.org/100022/diff/5/1004#newcode28
Line 28: // namespace {
On 2009/04/29 16:29:28, sky wrote:
> Why are you commenting out the namespace here?
sorry mistake.

[sky, 2009-05-04 15:29:44]

On 2009/05/01 03:32:18, Mohamed Mansour wrote:
> Hi sky, sorry for the late reply. I had major computer issues.
> 
> I really don't understand why we have the drag and drop for a Chrome menu. I
> don't see that functionality within Chrome. Is that for future implementation?

It's used by bookmarks. You can drag and drop to reorder bookmarks in folders on
the bookmark bar.

But I wasn't referring to actual drag and drop on the menu, rather dragging on a
menu that doesn't support drag and drop of the items. For example, right click
on a tab to get the context menu, click on a menu item and drag until the mouse
is outside the popup. Notice this exhibits the same behavior you're fixing for
mouse move.

  -Scott

[Mohamed Mansour (USE mhm), 2009-05-04 16:04:07]

Ah Thanks for the explanation Scott, it is a different fix than what we have
now, this fix just fixes the mouse hovered out. We could commit this (since it
fixes that issue on the bug tracker), and then I could figure out how to fix the
drag issue. I am going to install my new raptor hard drive tonight, so if you
could commit this change as step 1, and step 2 will be fixing the dragging
issues.

[sky, 2009-05-04 17:51:24]

Sure. I've landed your patch in r15220.

  -Scott

On 2009/05/04 16:04:07, Mohamed Mansour wrote:
> Ah Thanks for the explanation Scott, it is a different fix than what we have
> now, this fix just fixes the mouse hovered out. We could commit this (since it
> fixes that issue on the bug tracker), and then I could figure out how to fix
the
> drag issue. I am going to install my new raptor hard drive tonight, so if you
> could commit this change as step 1, and step 2 will be fixing the dragging
> issues.