Issue 1000213003: go/bindings/cgo: allocate C structs on C side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1000213003: go/bindings/cgo: allocate C structs on C side (Closed)

Created:
5 years, 9 months ago by rogulenko

Modified:
5 years, 9 months ago

Reviewers:
jamesr, jamesr1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

go/bindings/cgo: allocate C structs on C side Running a go mojo application on ARMv7 android I found out that C structs are not 8-byte aligned. To make sure that this happens we add a cheap wrapper fo cgo calls that takes a non-aligned C struct, copies it to properly allocated and makes a call to Mojo interface. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5062c7339b99172203ff60752e0975810426c9e1

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -5 lines)			Patch
	M	mojo/public/go/bindings/interface.go	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	mojo/public/platform/native_cgo/system_cgo.go	View		5 chunks	+29 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rogulenko

5 years, 9 months ago (2015-03-12 19:55:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5062c7339b99172203ff60752e0975810426c9e1 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages