chromecast/browser/metrics/cast_metrics_service_client.h - Issue 1000203007: Set a "metrics_client_id" crash key instead of "guid" on Mac OS X

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.h

Issue 1000203007: Set a "metrics_client_id" crash key instead of "guid" on Mac OS X (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review feedback (isherman) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/browser/metrics/cast_metrics_service_client.h

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.h b/chromecast/browser/metrics/cast_metrics_service_client.h

index ffa17a3f8d16b7aafbb4023b4e9751636c33a5dc..abc2b57311c5141d4f62052f2cb06d67e60cede9 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.h

+++ b/chromecast/browser/metrics/cast_metrics_service_client.h

@@ -51,6 +51,7 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {

// metrics::MetricsServiceClient implementation:

void SetMetricsClientId(const std::string& client_id) override;

+ void OnRecordingDisabled() override;

bool IsOffTheRecordSessionActive() override;

int32_t GetProduct() override;

std::string GetApplicationLocale() override;

« chrome/common/crash_keys.h ('K') | « chrome/common/crash_keys.cc ('k') | chromecast/browser/metrics/cast_metrics_service_client.cc » ('j') | no next file with comments »