Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: src/codegen-ia32.cc

Issue 10002: Use shorting encoding for mov reg, imm. (Closed)
Patch Set: Remove an accidental change Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/codegen-ia32.cc
diff --git a/src/codegen-ia32.cc b/src/codegen-ia32.cc
index 19f64b026927fb3b51503f13f31dbc9961d38213..f12052da241de2c10620c6e76c8fd2dcf1cbc7d6 100644
--- a/src/codegen-ia32.cc
+++ b/src/codegen-ia32.cc
@@ -1041,7 +1041,7 @@ void CodeGenerator::SmiOperation(Token::Value op,
} else {
deferred = new DeferredInlinedSmiSubReversed(this, edx, overwrite_mode);
__ mov(edx, Operand(eax));
- __ mov(Operand(eax), Immediate(value));
+ __ mov(eax, Immediate(value));
Kevin Millikin (Chromium) 2008/11/10 15:05:41 Couldn't this just be __ mov(eax, value)?
__ sub(eax, Operand(edx));
}
__ j(overflow, deferred->enter(), not_taken);
@@ -1265,7 +1265,7 @@ void SmiComparisonDeferred::Generate() {
CompareStub stub(cc_, strict_);
// Setup parameters and call stub.
__ mov(edx, Operand(eax));
- __ mov(Operand(eax), Immediate(Smi::FromInt(value_)));
+ __ Set(eax, Immediate(Smi::FromInt(value_)));
__ CallStub(&stub);
__ cmp(eax, 0);
// "result" is returned in the flags
@@ -4984,7 +4984,7 @@ void CEntryStub::GenerateBody(MacroAssembler* masm, bool is_debug_break) {
// running with --gc-greedy set.
if (FLAG_gc_greedy) {
Failure* failure = Failure::RetryAfterGC(0);
- __ mov(Operand(eax), Immediate(reinterpret_cast<int32_t>(failure)));
+ __ mov(eax, Immediate(reinterpret_cast<int32_t>(failure)));
Kevin Millikin (Chromium) 2008/11/10 15:05:41 Similarly __ mov(eax, reinterpret_cast<int32_t>(fa
}
GenerateCore(masm, &throw_normal_exception,
&throw_out_of_memory_exception,
@@ -5002,7 +5002,7 @@ void CEntryStub::GenerateBody(MacroAssembler* masm, bool is_debug_break) {
// Do full GC and retry runtime call one final time.
Failure* failure = Failure::InternalError();
- __ mov(Operand(eax), Immediate(reinterpret_cast<int32_t>(failure)));
+ __ mov(eax, Immediate(reinterpret_cast<int32_t>(failure)));
Kevin Millikin (Chromium) 2008/11/10 15:05:41 Ditto.
GenerateCore(masm,
&throw_normal_exception,
&throw_out_of_memory_exception,
@@ -5068,10 +5068,10 @@ void JSEntryStub::GenerateBody(MacroAssembler* masm, bool is_construct) {
// stub, because the builtin stubs may not have been generated yet.
if (is_construct) {
ExternalReference construct_entry(Builtins::JSConstructEntryTrampoline);
- __ mov(Operand(edx), Immediate(construct_entry));
+ __ mov(edx, Immediate(construct_entry));
} else {
ExternalReference entry(Builtins::JSEntryTrampoline);
- __ mov(Operand(edx), Immediate(entry));
+ __ mov(edx, Immediate(entry));
}
__ mov(edx, Operand(edx, 0)); // deref address
__ lea(edx, FieldOperand(edx, Code::kHeaderSize));
« no previous file with comments | « src/builtins-ia32.cc ('k') | src/ic-ia32.cc » ('j') | src/macro-assembler-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698