Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: sdk/lib/_internal/pub/lib/src/command/build.dart

Issue 1000193004: Read package:browser .js files from barback rather than from packages directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reformatted then() blocks. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/command/build.dart
diff --git a/sdk/lib/_internal/pub/lib/src/command/build.dart b/sdk/lib/_internal/pub/lib/src/command/build.dart
index 7a6685a60a69ec730d8f198baadd402b9b2ee40d..1a88922c2fc695bd85274821596ada401681426a 100644
--- a/sdk/lib/_internal/pub/lib/src/command/build.dart
+++ b/sdk/lib/_internal/pub/lib/src/command/build.dart
@@ -93,7 +93,8 @@ class BuildCommand extends BarbackCommand {
.map((asset) => asset.id);
return Future.wait(assets.map(_writeAsset)).then((_) {
- builtFiles += _copyBrowserJsFiles(dart2JSEntrypoints);
+ return _copyBrowserJsFiles(dart2JSEntrypoints, assets);
+ }).then((_) {
log.message('Built $builtFiles ${pluralize('file', builtFiles)} '
'to "$outputDirectory".');
@@ -190,13 +191,11 @@ class BuildCommand extends BarbackCommand {
/// If this package depends directly on the `browser` package, this ensures
/// that the JavaScript bootstrap files are copied into `packages/browser/`
/// directories next to each entrypoint in [entrypoints].
- ///
- /// Returns the number of files it copied.
- int _copyBrowserJsFiles(Iterable<AssetId> entrypoints) {
+ Future _copyBrowserJsFiles(Iterable<AssetId> entrypoints, AssetSet assets) {
// Must depend on the browser package.
if (!entrypoint.root.immediateDependencies.any(
(dep) => dep.name == 'browser' && dep.source == 'hosted')) {
- return 0;
+ return new Future.value();
}
// Get all of the subdirectories that contain Dart entrypoints.
@@ -209,29 +208,17 @@ class BuildCommand extends BarbackCommand {
.where((dir) => path.split(dir).length > 1)
.toSet();
- for (var dir in entrypointDirs) {
+ var jsAssets = assets.where((asset) =>
+ asset.id.package == 'browser' && asset.id.extension == '.js');
+ return Future.wait(entrypointDirs.expand((dir) {
// TODO(nweiz): we should put browser JS files next to any HTML file
// rather than any entrypoint. An HTML file could import an entrypoint
// that's not adjacent.
- _addBrowserJs(dir, "dart");
- _addBrowserJs(dir, "interop");
- }
-
- return entrypointDirs.length * 2;
- }
-
- // TODO(nweiz): do something more principled when issue 6101 is fixed.
- /// Ensures that the [name].js file is copied into [directory] in [target],
- /// under `packages/browser/`.
- void _addBrowserJs(String directory, String name) {
- var jsPath = entrypoint.root.path(
- outputDirectory, directory, 'packages', 'browser', '$name.js');
- ensureDir(path.dirname(jsPath));
-
- // TODO(rnystrom): This won't work if we get rid of symlinks and the top
- // level "packages" directory. Will need to copy from the browser
- // directory.
- copyFile(path.join(entrypoint.packagesDir, 'browser', '$name.js'), jsPath);
+ return jsAssets.map((asset) {
+ var jsPath = path.join(dir, _idToPath(asset.id));
+ return _writeOutputFile(asset, jsPath);
+ });
+ }));
}
/// Converts [entry] to a JSON object for use with JSON-formatted output.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698