Read package:browser .js files from barback rather than from packages directory.

sdk/lib/_internal/pub/lib/src/command/build.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pub.command.build;
 
 import 'dart:async';
 
 import 'package:barback/barback.dart';
 import 'package:path/path.dart' as path;
@@ skipping 74 matching lines @@
             (dir) => environment.serveDirectory(dir))).then((_) {
 
           return environment.barback.getAllAssets();
         });
       }).then((assets) {
         // Find all of the JS entrypoints we built.
         var dart2JSEntrypoints = assets
             .where((asset) => asset.id.path.endsWith(".dart.js"))
             .map((asset) => asset.id);
 
-        return Future.wait(assets.map(_writeAsset)).then((_) {
-          builtFiles += _copyBrowserJsFiles(dart2JSEntrypoints);
+        return Future.wait(assets.map(_writeAsset))
+          .then((_) => _copyBrowserJsFiles(dart2JSEntrypoints, assets))
+          .then((_) {

[Bob Nystrom, 2015/03/12 22:36:08]

In pub, we tend to leave .then() hanging on the right, so like:

         return Future.wait(assets.map(_writeAsset)).then((_) {
           return _copyBrowserJsFiles(dart2JSEntrypoints, assets);
         }).then((_) {

[Chris Bracken, 2015/03/12 22:52:42]

Done.

           log.message('Built $builtFiles ${pluralize('file', builtFiles)} '
               'to "$outputDirectory".');
 
           log.json.message({
             "buildResult": "success",
             "outputDirectory": outputDirectory,
             "numFiles": builtFiles,
             "log": logJson
           });
         });
@@ skipping 76 matching lines @@
   Future _writeOutputFile(Asset asset, String relativePath) {
     builtFiles++;
     var destPath = path.join(outputDirectory, relativePath);
     ensureDir(path.dirname(destPath));
     return createFileFromStream(asset.read(), destPath);
   }
 
   /// If this package depends directly on the `browser` package, this ensures
   /// that the JavaScript bootstrap files are copied into `packages/browser/`
   /// directories next to each entrypoint in [entrypoints].
-  ///
-  /// Returns the number of files it copied.

[Bob Nystrom, 2015/03/12 22:36:08]

Can you preserve this behavior? It should be fairly easy to do and the printed
output expects this.

[Chris Bracken, 2015/03/12 22:52:42]

Is there a good reason to? The new code uses _writeOutputFile() which increments
the count (line 185).

[Bob Nystrom, 2015/03/13 16:20:21]

Ack, my reading comprehension was bad here. Sorry.

-  int _copyBrowserJsFiles(Iterable<AssetId> entrypoints) {
+  Future _copyBrowserJsFiles(Iterable<AssetId> entrypoints, AssetSet assets) {

[Bob Nystrom, 2015/03/12 22:36:08]

Feel free to use async/await here to make your life easier. :)

     // Must depend on the browser package.
     if (!entrypoint.root.immediateDependencies.any(
         (dep) => dep.name == 'browser' && dep.source == 'hosted')) {
-      return 0;
+      return new Future.value();
     }
 
     // Get all of the subdirectories that contain Dart entrypoints.
     var entrypointDirs = entrypoints
         // Convert the asset path to a native-separated one and get the
         // directory containing the entrypoint.
         .map((id) => path.dirname(path.fromUri(id.path)))
         // Don't copy files to the top levels of the build directories since
         // the normal lib asset copying will take care of that.
         .where((dir) => path.split(dir).length > 1)
         .toSet();
 
-    for (var dir in entrypointDirs) {
+    var jsAssets = assets.where((asset) =>
+        asset.id.package == 'browser' && asset.id.extension == '.js');
+    return Future.wait(entrypointDirs.expand((dir) {
       // TODO(nweiz): we should put browser JS files next to any HTML file
       // rather than any entrypoint. An HTML file could import an entrypoint
       // that's not adjacent.
-      _addBrowserJs(dir, "dart");
-      _addBrowserJs(dir, "interop");
-    }
-
-    return entrypointDirs.length * 2;
-  }
-
-  // TODO(nweiz): do something more principled when issue 6101 is fixed.
-  /// Ensures that the [name].js file is copied into [directory] in [target],
-  /// under `packages/browser/`.
-  void _addBrowserJs(String directory, String name) {
-    var jsPath = entrypoint.root.path(
-        outputDirectory, directory, 'packages', 'browser', '$name.js');
-    ensureDir(path.dirname(jsPath));
-
-    // TODO(rnystrom): This won't work if we get rid of symlinks and the top
-    // level "packages" directory. Will need to copy from the browser
-    // directory.
-    copyFile(path.join(entrypoint.packagesDir, 'browser', '$name.js'), jsPath);
+      return jsAssets.map((asset) {
+        var jsPath = path.join(dir, _idToPath(asset.id));
+        return _writeOutputFile(asset, jsPath);
+      });
+    }));
   }
 
   /// Converts [entry] to a JSON object for use with JSON-formatted output.
   Map _logEntryToJson(LogEntry entry) {
     var data = {
       "level": entry.level.name,
       "transformer": {
         "name": entry.transform.transformer.toString(),
         "primaryInput": {
           "package": entry.transform.primaryId.package,
@@ skipping 17 matching lines @@
         "end": {
           "line": entry.span.end.line,
           "column": entry.span.end.column
         },
       };
     }
 
     return data;
   }
 }