Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1000163005: [AiS] using const for vertical padding (Closed)

Created:
5 years, 9 months ago by dschuyler
Modified:
5 years, 9 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, James Su, groby-ooo-7-16, Justin Donnelly
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[AiS] using kMinimumTextVerticalPadding rather than member variables for vertical padding. (Separated out from CL 795933009) BUG=455418 Committed: https://crrev.com/5b3b5620baf043e7c71f447007cf958c18be54b8 Cr-Commit-Position: refs/heads/master@{#321223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -31 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 3 chunks +9 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 4 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dschuyler
5 years, 9 months ago (2015-03-18 21:06:36 UTC) #2
Peter Kasting
LGTM
5 years, 9 months ago (2015-03-18 22:27:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000163005/1
5 years, 9 months ago (2015-03-18 22:29:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 22:41:02 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 22:41:43 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5b3b5620baf043e7c71f447007cf958c18be54b8
Cr-Commit-Position: refs/heads/master@{#321223}

Powered by Google App Engine
This is Rietveld 408576698