Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: BUILD.gn

Issue 1000163003: Generate the icu data binaries at compile time instead of checking in binaries Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Fixed warnings in cross compiling Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | README.chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 4e8e540349bd175ff37b22ce15d71c3ba66a8067..cccce992a0060eff7aa4e7124237a0be3cee25bd 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -492,65 +492,8 @@ component("icuuc") {
}
}
-# TODO(GYP) support use_system_icu.
-if (icu_use_data_file) {
- if (is_ios) {
- # TODO(GYP): Support mac resource bundle shown below.
- # 'link_settings': {
- # 'mac_bundle_resources': [
- # 'source/data/in/icudtl.dat',
- # ],
- # }
- } else {
- copy("icudata") {
- if (is_android) {
- sources = [
- "android/icudtl.dat",
- ]
- } else {
- sources = [
- "source/data/in/icudtl.dat",
- ]
- }
-
- outputs = [
- "$root_out_dir/icudtl.dat",
- ]
- }
- }
-} else {
- if (is_win) {
- # On Windows the target DLL is pre-built so just use a copy rule.
- copy("icudata") {
- sources = [
- "windows/icudt.dll",
- ]
- outputs = [
- "$root_out_dir/icudt.dll",
- ]
- }
- } else {
- source_set("icudata") {
- # These are hand-generated, but will do for now.
- #
- # TODO(GYP): Gyp has considerations here for QNX and for the host toolchain
- # that have not been ported over.
- if (is_linux) {
- sources = [
- "linux/icudtl_dat.S",
- ]
- } else if (is_mac) {
- sources = [
- "mac/icudtl_dat.S",
- ]
- } else if (is_android) {
- sources = [
- "android/icudtl_dat.S",
- ]
- } else {
- assert(false, "No icu data for this platform")
- }
- defines = [ "U_HIDE_DATA_SYMBOL" ]
- }
- }
+group("icudata") {
+ deps = [
+ "gn_data_build_system:icu_data"
+ ]
}
« no previous file with comments | « no previous file | README.chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698