Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: BUILD.gn

Issue 1000163003: Generate the icu data binaries at compile time instead of checking in binaries Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Polishing and making BUILD.gn smaller Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | README.chromium » ('j') | gn_data_build_system/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/icu/config.gni") 5 import("//third_party/icu/config.gni")
6 6
7 # Meta target that includes both icuuc and icui18n. Most targets want both. 7 # Meta target that includes both icuuc and icui18n. Most targets want both.
8 # You can depend on the individually if you need to. 8 # You can depend on the individually if you need to.
9 group("icu") { 9 group("icu") {
10 deps = [ 10 deps = [
(...skipping 474 matching lines...) Expand 10 before | Expand all | Expand 10 after
485 ] 485 ]
486 486
487 public_configs = [ ":icu_config" ] 487 public_configs = [ ":icu_config" ]
488 488
489 if (is_win || icu_use_data_file) { 489 if (is_win || icu_use_data_file) {
490 sources += [ "source/stubdata/stubdata.c" ] 490 sources += [ "source/stubdata/stubdata.c" ]
491 defines += [ "U_ICUDATAENTRY_IN_COMMON" ] 491 defines += [ "U_ICUDATAENTRY_IN_COMMON" ]
492 } 492 }
493 } 493 }
494 494
495 # TODO(GYP) support use_system_icu. 495 group("icudata") {
496 if (icu_use_data_file) { 496 deps = [
497 if (is_ios) { 497 "gn_data_build_system:icu_data"
498 # TODO(GYP): Support mac resource bundle shown below. 498 ]
499 # 'link_settings': { 499 }
500 # 'mac_bundle_resources': [
501 # 'source/data/in/icudtl.dat',
502 # ],
503 # }
504 } else {
505 copy("icudata") {
506 if (is_android) {
507 sources = [
508 "android/icudtl.dat",
509 ]
510 } else {
511 sources = [
512 "source/data/in/icudtl.dat",
513 ]
514 }
515 500
516 outputs = [ 501 # # TODO(GYP) support use_system_icu.
517 "$root_out_dir/icudtl.dat", 502 # if (icu_use_data_file) {
518 ] 503 # if (is_ios) {
519 } 504 # # TODO(GYP): Support mac resource bundle shown below.
520 } 505 # # 'link_settings': {
521 } else { 506 # # 'mac_bundle_resources': [
522 if (is_win) { 507 # # 'source/data/in/icudtl.dat',
523 # On Windows the target DLL is pre-built so just use a copy rule. 508 # # ],
524 copy("icudata") { 509 # # }
525 sources = [ 510 # } else {
526 "windows/icudt.dll", 511 # copy("icudata") {
527 ] 512 # if (is_android) {
528 outputs = [ 513 # sources = [
529 "$root_out_dir/icudt.dll", 514 # "android/icudtl.dat",
530 ] 515 # ]
531 } 516 # } else {
532 } else { 517 # sources = [
533 source_set("icudata") { 518 # "source/data/in/icudtl.dat",
534 # These are hand-generated, but will do for now. 519 # ]
535 # 520 # }
536 # TODO(GYP): Gyp has considerations here for QNX and for the host toolchai n 521
537 # that have not been ported over. 522 # outputs = [
538 if (is_linux) { 523 # "$root_out_dir/icudtl.dat",
539 sources = [ 524 # ]
540 "linux/icudtl_dat.S", 525 # }
541 ] 526 # }
542 } else if (is_mac) { 527 # } else {
543 sources = [ 528 # if (is_win) {
544 "mac/icudtl_dat.S", 529 # # On Windows the target DLL is pre-built so just use a copy rule.
545 ] 530 # copy("icudata") {
546 } else if (is_android) { 531 # sources = [
547 sources = [ 532 # "windows/icudt.dll",
548 "android/icudtl_dat.S", 533 # ]
549 ] 534 # outputs = [
550 } else { 535 # "$root_out_dir/icudt.dll",
551 assert(false, "No icu data for this platform") 536 # ]
552 } 537 # }
553 defines = [ "U_HIDE_DATA_SYMBOL" ] 538 # } else {
554 } 539 # source_set("icudata") {
555 } 540 # # These are hand-generated, but will do for now.
556 } 541 # #
542 # # TODO(GYP): Gyp has considerations here for QNX and for the host toolch ain
543 # # that have not been ported over.
544 # if (is_linux) {
545 # sources = [
546 # "linux/icudtl_dat.S",
547 # ]
548 # } else if (is_mac) {
549 # sources = [
550 # "mac/icudtl_dat.S",
551 # ]
552 # } else if (is_android) {
553 # sources = [
554 # "android/icudtl_dat.S",
555 # ]
556 # } else {
557 # assert(false, "No icu data for this platform")
558 # }
559 # defines = [ "U_HIDE_DATA_SYMBOL" ]
560 # }
561 # }
562 # }
OLDNEW
« no previous file with comments | « no previous file | README.chromium » ('j') | gn_data_build_system/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698