downloads: put [column-type] in HTML template instead of JS.

chrome/browser/resources/downloads/manager.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('downloads', function() {
   /**
    * Class to own and manage download items.
    * @constructor
    */
   function Manager() {}
@@ skipping 84 matching lines @@
       noDownloadsOrResults.hidden = hasDownloads;
 
       if (loadTimeData.getBoolean('allow_deleting_history'))
         $('clear-all').hidden = !hasDownloads || this.searchText_.length > 0;
 
       this.rebuildFocusGrid_();
     },
 
     /** @param {!downloads.Data} data Info about the item to update. */
     updateItem: function(data) {
-      this.idMap_[data.id].render(data);
+      var item = this.idMap_[data.id];
+      item.render(data);
+      this.decorateItem_(item);
     },
 
     /**
      * Rebuild the focusGrid_ using the elements that each download will have.
      * @private
      */
     rebuildFocusGrid_: function() {
-      var activeElement = document.activeElement;
-
       /** @private {!cr.ui.FocusGrid} */
       this.focusGrid_ = this.focusGrid_ || new cr.ui.FocusGrid();
       this.focusGrid_.destroy();
+      this.items_.forEach(this.decorateItem_, this);
+    },
 
-      this.items_.forEach(function(item) {
-        downloads.FocusRow.decorate(item.view.node, item.view, this.node_);
-        var focusRow = assertInstanceof(item.view.node, downloads.FocusRow);
+    /**
+     * @param {!download.Item} item An item to decorate as a downloads.FocusRow.
+     */
+    decorateItem_: function(item) {
+      var activeElement = document.activeElement;
+
+      downloads.FocusRow.decorate(item.view.node, item.view, this.node_);
+      var focusRow = assertInstanceof(item.view.node, downloads.FocusRow);
+
+      if (this.focusGrid_.rows.indexOf(focusRow) < 0)
         this.focusGrid_.addRow(focusRow);
 
-        // Focus the equivalent element in the focusRow because the active
-        // element may no longer be visible.
-        if (focusRow.contains(activeElement))
-          focusRow.getEquivalentElement(activeElement).focus();
-      }, this);
+      // Focus the equivalent element in the focusRow because the active
+      // element may no longer be visible.
+      if (focusRow.focusableElements.indexOf(activeElement) >= 0 &&

[hcarmona, 2015/03/12 19:12:52]

This should stay "if (focusRow.contains(activeElement))" because we want to
update focus for the row that contains the active element and |activeElement|
may be hidden. The call to |getEquivalentElement| will ensure that the element
that you call |focus| on is visible.

[Dan Beam, 2015/03/12 20:19:03]

Fixed (differently though, see updated code)

+          activeElement != document.activeElement) {
+        focusRow.getEquivalentElement(activeElement).focus();
+      }
     },
 
     /** @return {number} The number of downloads shown on the page. */
     size: function() {
       return this.items_.length;
     },
 
     clearAll: function() {
       if (loadTimeData.getBoolean('allow_deleting_history')) {
         chrome.send('clearAll');
@@ skipping 63 matching lines @@
   };
 
   Manager.size = function() {
     return Manager.getInstance().size();
   };
 
   return {Manager: Manager};
 });
 
 window.addEventListener('DOMContentLoaded', downloads.Manager.onLoad);