Hide RegExp and String initialization in a closure.

Hide RegExp and String initialization in a closure.

R=jkummerow@chromium.org

Committed: https://crrev.com/4e9daf4e3d13089d0bfbe4f690aa792f2d21bffb
Cr-Commit-Position: refs/heads/master@{#27161}

[Jakob Kummerow, 2015-03-12 12:46:35]

LGTM with comments.

https://codereview.chromium.org/1000063002/diff/1/src/string.js
File src/string.js (right):

https://codereview.chromium.org/1000063002/diff/1/src/string.js#newcode940
src/string.js:940: %AddNamedProperty(GlobalString.prototype, "constructor",
GlobalString, DONT_ENUM);
nit: 80col

https://codereview.chromium.org/1000063002/diff/1/src/string.js#newcode943
src/string.js:943: InstallFunctions(GlobalString, DONT_ENUM, $Array(
Why "$Array"? Other files use "var GlobalArray = global.Array" for this; I
assume the "$Array = ..." definition in runtime.js is deprecated.

(again below)

[Yang, 2015-03-12 14:26:37]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-03-12 14:26:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1000063002/#ps20001
(title: "address comments")

[Yang, 2015-03-12 14:26:38]

On 2015/03/12 12:46:35, Jakob wrote:
> LGTM with comments.
> 
> https://codereview.chromium.org/1000063002/diff/1/src/string.js
> File src/string.js (right):
> 
> https://codereview.chromium.org/1000063002/diff/1/src/string.js#newcode940
> src/string.js:940: %AddNamedProperty(GlobalString.prototype, "constructor",
> GlobalString, DONT_ENUM);
> nit: 80col
> 
> https://codereview.chromium.org/1000063002/diff/1/src/string.js#newcode943
> src/string.js:943: InstallFunctions(GlobalString, DONT_ENUM, $Array(
> Why "$Array"? Other files use "var GlobalArray = global.Array" for this; I
> assume the "$Array = ..." definition in runtime.js is deprecated.
> 
> (again below)

Done. Thanks.

[commit-bot: I haz the power, 2015-03-12 14:26:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1000063002/20001

[commit-bot: I haz the power, 2015-03-12 14:47:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-12 14:48:00]

Patchset 2 (id:??) landed as
https://crrev.com/4e9daf4e3d13089d0bfbe4f690aa792f2d21bffb
Cr-Commit-Position: refs/heads/master@{#27161}