Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 100003003: MIPS: Tidy up Throw and Mod (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1436 matching lines...) Expand 10 before | Expand all | Expand 10 after
1447 1447
1448 LInstruction* LChunkBuilder::DoMod(HMod* instr) { 1448 LInstruction* LChunkBuilder::DoMod(HMod* instr) {
1449 HValue* left = instr->left(); 1449 HValue* left = instr->left();
1450 HValue* right = instr->right(); 1450 HValue* right = instr->right();
1451 if (instr->representation().IsSmiOrInteger32()) { 1451 if (instr->representation().IsSmiOrInteger32()) {
1452 ASSERT(instr->left()->representation().Equals(instr->representation())); 1452 ASSERT(instr->left()->representation().Equals(instr->representation()));
1453 ASSERT(instr->right()->representation().Equals(instr->representation())); 1453 ASSERT(instr->right()->representation().Equals(instr->representation()));
1454 if (instr->HasPowerOf2Divisor()) { 1454 if (instr->HasPowerOf2Divisor()) {
1455 ASSERT(!right->CanBeZero()); 1455 ASSERT(!right->CanBeZero());
1456 LModI* mod = new(zone()) LModI(UseRegisterAtStart(left), 1456 LModI* mod = new(zone()) LModI(UseRegisterAtStart(left),
1457 UseOrConstant(right)); 1457 UseConstant(right));
1458 LInstruction* result = DefineAsRegister(mod); 1458 LInstruction* result = DefineAsRegister(mod);
1459 return (left->CanBeNegative() && 1459 return (left->CanBeNegative() &&
1460 instr->CheckFlag(HValue::kBailoutOnMinusZero)) 1460 instr->CheckFlag(HValue::kBailoutOnMinusZero))
1461 ? AssignEnvironment(result) 1461 ? AssignEnvironment(result)
1462 : result; 1462 : result;
1463 } else { 1463 } else {
1464 LModI* mod = new(zone()) LModI(UseRegister(left), 1464 LModI* mod = new(zone()) LModI(UseRegister(left),
1465 UseRegister(right), 1465 UseRegister(right),
1466 TempRegister(), 1466 TempRegister(),
1467 FixedTemp(f20), 1467 FixedTemp(f20),
(...skipping 1129 matching lines...) Expand 10 before | Expand all | Expand 10 after
2597 2597
2598 2598
2599 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2599 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2600 LOperand* object = UseRegister(instr->object()); 2600 LOperand* object = UseRegister(instr->object());
2601 LOperand* index = UseRegister(instr->index()); 2601 LOperand* index = UseRegister(instr->index());
2602 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2602 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2603 } 2603 }
2604 2604
2605 2605
2606 } } // namespace v8::internal 2606 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698