Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 999983004: simMutex (Closed)

Created:
5 years, 9 months ago by koda
Modified:
5 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Isolate -> Thread for tracking owner of mutex and simulator's exclusive access. Prepares for multiple threads referencing the same isolate (in particular, the mutator and sweeper). R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44762

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -113 lines) Patch
M runtime/vm/freelist.cc View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/os_thread.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/os_thread_android.cc View 1 2 3 4 5 6 7 6 chunks +6 lines, -7 lines 0 comments Download
M runtime/vm/os_thread_linux.cc View 1 2 3 4 5 6 7 8 6 chunks +6 lines, -7 lines 0 comments Download
M runtime/vm/os_thread_macos.cc View 1 2 3 4 5 6 7 6 chunks +6 lines, -7 lines 0 comments Download
M runtime/vm/os_thread_win.cc View 1 2 3 4 5 6 7 6 chunks +6 lines, -7 lines 0 comments Download
M runtime/vm/pages.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/simulator_arm.h View 1 2 3 4 2 chunks +11 lines, -11 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 2 3 4 5 chunks +14 lines, -14 lines 0 comments Download
M runtime/vm/simulator_arm64.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +11 lines, -11 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 2 3 4 5 6 7 8 9 10 5 chunks +14 lines, -14 lines 0 comments Download
M runtime/vm/simulator_mips.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +11 lines, -11 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 1 2 3 4 5 6 7 8 9 10 5 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
koda
5 years, 9 months ago (2015-03-25 23:09:35 UTC) #2
koda
Updated to simplify the assertion (no need to expose the type of the owner), and ...
5 years, 9 months ago (2015-03-27 17:21:04 UTC) #3
siva
LGTM. As discussed offline we may at one point want an assertion to ensure that ...
5 years, 9 months ago (2015-03-27 17:58:21 UTC) #4
koda
5 years, 9 months ago (2015-03-27 20:33:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #11 (id:200001) manually as r44762 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698