dart2js: emit info on lazy fields in array.

dart2js: emit info on lazy fields in array.

R=herhut@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44830

[zarah, 2015-03-24 08:34:04]

zarah@google.com changed reviewers:
+ herhut@google.com

[floitsch, 2015-03-24 16:28:16]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-03-24 16:28:17]

DBC.

https://codereview.chromium.org/999933007/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/999933007/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:892:
js.string(element.name),
nit: indentation seems off.

[herhut, 2015-04-01 07:43:05]

lgtm w/ comments

https://codereview.chromium.org/999933007/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/999933007/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:857: {
Why the block? If you were hoping for a new variable scope, JavaScript won't
give that to you. For that, you need a function. Maybe a layout like

(function(lazies) { ...code...})([lazieslist])

would be better anyway.

https://codereview.chromium.org/999933007/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:871: #lazy(prototype,
staticName, fieldName, getterName, lazyValue);
This has become a little more complicated now, as staticName may or may not
exist depending on whether we are in minified mode.

[zarah, 2015-04-01 11:05:08]

https://codereview.chromium.org/999933007/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/999933007/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:857: {
On 2015/04/01 07:43:05, herhut wrote:
> Why the block? If you were hoping for a new variable scope, JavaScript won't
> give that to you. For that, you need a function. Maybe a layout like
> 
> (function(lazies) { ...code...})([lazieslist])
> 
> would be better anyway.

No it was to have a single statement. Changed it to your suggestion.

https://codereview.chromium.org/999933007/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:871: #lazy(prototype,
staticName, fieldName, getterName, lazyValue);
On 2015/04/01 07:43:05, herhut wrote:
> This has become a little more complicated now, as staticName may or may not
> exist depending on whether we are in minified mode.

Changed to handle this.

https://codereview.chromium.org/999933007/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:892:
js.string(element.name),
On 2015/03/24 16:28:17, floitsch wrote:
> nit: indentation seems off.

Done.

[zarah, 2015-04-01 11:07:41]

Committed patchset #2 (id:20001) manually as 44830 (presubmit successful).