Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 999923002: completions for function return type (Closed)

Created:
5 years, 9 months ago by danrubel
Modified:
5 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

completions for function return type BUG=dartbug.com/22686 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44415

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -1 line) Patch
M pkg/analysis_server/lib/src/services/completion/optype.dart View 2 chunks +11 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_target_test.dart View 1 chunk +145 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +94 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 1 chunk +149 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 9 months ago (2015-03-11 21:11:00 UTC) #2
scheglov
LGTM
5 years, 9 months ago (2015-03-11 21:18:11 UTC) #3
danrubel
5 years, 9 months ago (2015-03-11 21:20:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44415 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698