Issue 99943006: Remove <script></script> comment in dart.js, which would allow people to inline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99943006: Remove <script></script> comment in dart.js, which would allow people to inline (Closed)

Created:
6 years, 11 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 11 months ago

Reviewers:
vsm, dgrove

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove <script></script> comment in dart.js, which would allow people to inline the code in page. People playing with inlining scripts in HTML should load the compiled code directly, but this doesn't hurt. R=dgrove@google.com Committed: https://code.google.com/p/dart/source/detail?r=31434

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	pkg/browser/lib/dart.js	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
	M	pkg/browser/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

6 years, 11 months ago (2014-01-02 22:38:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r31434 (presubmit successful).

Expand Messages | Collapse Messages