Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 999323002: Add angular2 version specification file (Closed)

Created:
5 years, 9 months ago by ricow1
Modified:
5 years, 9 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add angular2 version specification file This is to be used for validation that we are running benchmarks against the correct version of angular2 (i.e., avoid backfilling on top of non comparable results). Additionally, it will give us a clear commit of when we updated with regressions/improvements showing up with the correct "blame". R=het@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44424

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
A tools/dart2js/angular2_testing_deps/CURRENT_ANGULAR_DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A tools/dart2js/angular2_testing_deps/README View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
5 years, 9 months ago (2015-03-12 08:53:27 UTC) #1
Harry Terkelsen
lgtm
5 years, 9 months ago (2015-03-12 08:57:11 UTC) #2
ricow1
5 years, 9 months ago (2015-03-12 08:57:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 44424 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698