Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 999213002: Add a bit of info to flow graph printout (Closed)

Created:
5 years, 9 months ago by hausner
Modified:
5 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add a bit of info to flow graph printout Add index of LoadLocal and StoreLocal instructions so we can distinguish between variables that have the same name but are distinct, e.g. :saved_try_context_var for different try statements. Also add a B prefix to the target of a goto, to make searching easier. TBR=fschneider Committed: https://code.google.com/p/dart/source/detail?r=44417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M runtime/vm/il_printer.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 9 months ago (2015-03-11 21:38:39 UTC) #2
hausner
Committed patchset #1 (id:1) manually as r44417 (presubmit successful).
5 years, 9 months ago (2015-03-11 21:39:01 UTC) #3
Florian Schneider
5 years, 9 months ago (2015-03-16 09:08:11 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698