Ensure that descriptors have a prototype.

Ensure that descriptors have a prototype.

BUG= http://dartbug.com/22776
R=floitsch@google.com, karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44401

[floitsch, 2015-03-11 13:11:48]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-03-11 13:11:49]

LGTM.

https://codereview.chromium.org/998983002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/998983002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:58: var
newDesc = {};
comment why not map().

https://codereview.chromium.org/998983002/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/998983002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:479: if
(!Object.hasOwnProperty.call(properties, member)) {
This should not be necessary (and always be false).

[herhut, 2015-03-11 13:36:24]

https://codereview.chromium.org/998983002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/998983002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:58: var
newDesc = {};
On 2015/03/11 13:11:49, floitsch wrote:
> comment why not map().

Done.

https://codereview.chromium.org/998983002/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/998983002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:479: if
(!Object.hasOwnProperty.call(properties, member)) {
On 2015/03/11 13:11:49, floitsch wrote:
> This should not be necessary (and always be false).

Done.

[herhut, 2015-03-11 13:39:18]

Committed patchset #4 (id:60001) manually as 44401 (presubmit successful).