Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 99893002: Revert "Revert r30650: fails in dart2js minified mode." and mark as failing. (Closed)

Created:
7 years ago by rmacnak
Modified:
7 years ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Revert r30650: fails in dart2js minified mode." and mark as failing. BUG=http://dartbug.com/15405 Committed: https://code.google.com/p/dart/source/detail?r=30802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M pkg/pkg.status View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/unittest/lib/mirror_matchers.dart View 1 chunk +10 lines, -1 line 0 comments Download
M pkg/unittest/test/mirror_matchers_test.dart View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rmacnak
Committed patchset #1 manually as r30802 (presubmit successful).
7 years ago (2013-12-02 19:24:06 UTC) #1
ahe
7 years ago (2013-12-02 19:46:58 UTC) #2
Message was sent while issue was closed.
LGTM, assuming the only change to r30650 is adding a status line.

Powered by Google App Engine
This is Rietveld 408576698