Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 998843003: pkg/csslib: formatting (Closed)

Created:
5 years, 9 months ago by kevmoo
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/csslib@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+1482 lines, -1379 lines) Patch
M example/call_parser.dart View 5 chunks +15 lines, -14 lines 1 comment Download
M lib/css.dart View 2 chunks +9 lines, -7 lines 1 comment Download
M lib/parser.dart View 51 chunks +427 lines, -429 lines 0 comments Download
M lib/src/analyzer.dart View 17 chunks +42 lines, -42 lines 0 comments Download
M lib/src/css_printer.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/messages.dart View 5 chunks +17 lines, -11 lines 1 comment Download
M lib/src/options.dart View 2 chunks +35 lines, -26 lines 0 comments Download
M lib/src/polyfill.dart View 6 chunks +9 lines, -11 lines 0 comments Download
M lib/src/property.dart View 37 chunks +112 lines, -103 lines 0 comments Download
M lib/src/token.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/src/tokenizer.dart View 21 chunks +59 lines, -52 lines 0 comments Download
M lib/src/tokenizer_base.dart View 8 chunks +22 lines, -22 lines 0 comments Download
M lib/src/tokenkind.dart View 14 chunks +425 lines, -374 lines 0 comments Download
M lib/src/tree.dart View 52 chunks +157 lines, -133 lines 0 comments Download
M lib/src/tree_base.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/tree_printer.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M lib/src/validate.dart View 6 chunks +10 lines, -12 lines 0 comments Download
M lib/visitor.dart View 7 chunks +23 lines, -23 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 2 comments Download
M test/big_1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/compiler_test.dart View 4 chunks +14 lines, -14 lines 0 comments Download
M test/declaration_test.dart View 5 chunks +24 lines, -31 lines 0 comments Download
M test/error_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M test/extend_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M test/mixin_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/nested_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M test/selector_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M test/testing.dart View 2 chunks +15 lines, -10 lines 0 comments Download
M test/var_test.dart View 10 chunks +38 lines, -33 lines 0 comments Download
M test/visitor_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
More fun to come, but starting with formatting
5 years, 9 months ago (2015-03-19 19:24:09 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 9 months ago (2015-03-19 20:21:01 UTC) #3
kevmoo
Committed patchset #1 (id:1) manually as ec47384e657686c5a5ba14e9003b7f4e8c76702e (presubmit successful).
5 years, 9 months ago (2015-03-19 20:24:19 UTC) #4
Jennifer Messerly
https://codereview.chromium.org/998843003/diff/1/example/call_parser.dart File example/call_parser.dart (right): https://codereview.chromium.org/998843003/diff/1/example/call_parser.dart#newcode34 example/call_parser.dart:34: 'color: red; left: 20px; top: 20px; width: 100px; height:200px' ...
5 years, 9 months ago (2015-03-19 20:25:31 UTC) #5
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-19 20:27:10 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/998843003/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/998843003/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.11.1-dev
On 2015/03/19 20:25:30, John Messerly wrote:
> reformatting could be a patch release?

+1

Powered by Google App Engine
This is Rietveld 408576698