Issue 998343002: Add a generate script to generate the googleapis libraries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 998343002: Add a generate script to generate the googleapis libraries. (Closed)

Created:
5 years, 9 months ago by wibling

Modified:
5 years, 9 months ago

Reviewers:
Søren Gjesse, kustermann

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/googleapis.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add a generate script to generate the googleapis libraries. This code is taken from the discoveryapis_generator and moved here since it was specific to the googleapis generation. R=kustermann@google.com, sgjesse@google.com BUG= Committed: https://github.com/dart-lang/googleapis/commit/b10f6b497622d301b0131e044a794bb03625a5c0

Patch Set 1 #

Total comments: 2

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+432 lines, -16 lines)			Patch
M	README.md	View	2 chunks	+1 line, -3 lines	0 comments	Download
A	bin/generate.dart	View	1 chunk	+87 lines, -0 lines	1 comment	Download
A	lib/googleapis_generator.dart	View	1 chunk	+78 lines, -0 lines	0 comments	Download
A	lib/src/package_configuration.dart	View	1 chunk	+260 lines, -0 lines	0 comments	Download
M	pubspec.lock	View	2 chunks	+5 lines, -8 lines	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -5 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM! Thanks for cleaning this up. https://codereview.chromium.org/998343002/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/998343002/diff/1/pubspec.yaml#newcode6 pubspec.yaml:6: discoveryapis_generator: '>=0.6.0 <0.7.0' ...

5 years, 9 months ago (2015-03-12 15:43:08 UTC) #2

kustermann

lgtm https://codereview.chromium.org/998343002/diff/1/bin/generate.dart File bin/generate.dart (right): https://codereview.chromium.org/998343002/diff/1/bin/generate.dart#newcode69 bin/generate.dart:69: var subCommands = ['download', 'generate', 'run_config']; Remove 'generate' ...

5 years, 9 months ago (2015-03-12 15:46:43 UTC) #3

wibling

5 years, 9 months ago (2015-03-27 12:12:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b10f6b497622d301b0131e044a794bb03625a5c0 (presubmit successful).

Expand Messages | Collapse Messages