Issue 998053002: Task: Build Public Namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 998053002: Task: Build Public Namespace. (Closed)

Created:
5 years, 9 months ago by scheglov

Modified:
5 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Task: Build Public Namespace. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44413

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+253 lines, -64 lines)			Patch
M	pkg/analyzer/lib/src/task/dart.dart	View	1 chunk	+55 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/task/dart.dart	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_test.dart	View	7 chunks	+189 lines, -64 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/998053002/diff/1/pkg/analyzer/test/src/task/dart_test.dart File pkg/analyzer/test/src/task/dart_test.dart (right): https://codereview.chromium.org/998053002/diff/1/pkg/analyzer/test/src/task/dart_test.dart#newcode456 pkg/analyzer/test/src/task/dart_test.dart:456: expect(inputs.keys, unorderedEquals([ I'd rather have the explicit test ...

5 years, 9 months ago (2015-03-11 20:55:25 UTC) #2

scheglov

5 years, 9 months ago (2015-03-11 21:03:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44413 (presubmit successful).

Expand Messages | Collapse Messages