Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 997503002: Add case to avoid warning when dart2js analyzes dart:io files (Closed)

Created:
5 years, 9 months ago by Søren Gjesse
Modified:
5 years, 9 months ago
Reviewers:
Bill Hesse, karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add case to avoid warning when dart2js analyzes dart:io files R=whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44360

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M sdk/lib/io/secure_socket.dart View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 6 (1 generated)
Søren Gjesse
5 years, 9 months ago (2015-03-10 09:14:42 UTC) #1
Bill Hesse
lgtm
5 years, 9 months ago (2015-03-10 09:18:54 UTC) #2
Søren Gjesse
Committed patchset #1 (id:1) manually as 44360 (presubmit successful).
5 years, 9 months ago (2015-03-10 09:19:48 UTC) #3
karlklose
LGTM. https://codereview.chromium.org/997503002/diff/1/sdk/lib/io/secure_socket.dart File sdk/lib/io/secure_socket.dart (right): https://codereview.chromium.org/997503002/diff/1/sdk/lib/io/secure_socket.dart#newcode563 sdk/lib/io/secure_socket.dart:563: dynamic s = _socket; // Cast to dynamic ...
5 years, 9 months ago (2015-03-10 09:20:40 UTC) #5
Søren Gjesse
5 years, 9 months ago (2015-03-10 16:29:01 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/997503002/diff/1/sdk/lib/io/secure_socket.dart
File sdk/lib/io/secure_socket.dart (right):

https://codereview.chromium.org/997503002/diff/1/sdk/lib/io/secure_socket.dar...
sdk/lib/io/secure_socket.dart:563: dynamic s = _socket;  // Cast to dynamic to
avoid warning.
On 2015/03/10 09:20:40, karlklose wrote:
> 'var s' would be shorter. Is there a better type you could use for _socket?

The type is _RawSocket, but that is currently defined in the patch file.

Powered by Google App Engine
This is Rietveld 408576698