Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 997203002: Add FunctionElement.isEntryPoint getter. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add FunctionElement.isEntryPoint getter. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44407

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 3 chunks +16 lines, -0 lines 2 comments Download
M pkg/analyzer/lib/src/generated/element_handle.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 4 chunks +3 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
5 years, 9 months ago (2015-03-11 17:14:07 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/997203002/diff/1/pkg/analyzer/lib/src/generated/element.dart File pkg/analyzer/lib/src/generated/element.dart (right): https://codereview.chromium.org/997203002/diff/1/pkg/analyzer/lib/src/generated/element.dart#newcode3949 pkg/analyzer/lib/src/generated/element.dart:3949: static final String LOAD_LIBRARY_NAME = "loadLibrary"; Could you ...
5 years, 9 months ago (2015-03-11 17:19:23 UTC) #2
scheglov
https://codereview.chromium.org/997203002/diff/1/pkg/analyzer/lib/src/generated/element.dart File pkg/analyzer/lib/src/generated/element.dart (right): https://codereview.chromium.org/997203002/diff/1/pkg/analyzer/lib/src/generated/element.dart#newcode3949 pkg/analyzer/lib/src/generated/element.dart:3949: static final String LOAD_LIBRARY_NAME = "loadLibrary"; On 2015/03/11 17:19:23, ...
5 years, 9 months ago (2015-03-11 17:21:00 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as 44407 (presubmit successful).
5 years, 9 months ago (2015-03-11 17:22:33 UTC) #4
scheglov
5 years, 9 months ago (2015-03-11 17:22:58 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 44407 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698