Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 996773002: Fix NPE in ContextManager (Closed)

Created:
5 years, 9 months ago by Brian Wilkerson
Modified:
5 years, 9 months ago
Reviewers:
Paul Berry, jwren
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
I caught the issue by running the server integration tests.
5 years, 9 months ago (2015-03-10 16:05:56 UTC) #2
Paul Berry
lgtm
5 years, 9 months ago (2015-03-10 16:10:09 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as 44376 (presubmit successful).
5 years, 9 months ago (2015-03-10 16:13:54 UTC) #4
jwren
5 years, 9 months ago (2015-03-10 16:19:04 UTC) #5
Message was sent while issue was closed.
On 2015/03/10 16:13:54, Brian Wilkerson wrote:
> Committed patchset #1 (id:1) manually as 44376 (presubmit successful).

LGTM

Powered by Google App Engine
This is Rietveld 408576698