Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 996103002: Fix handling of lazy and and or in async functions. (Closed)

Created:
5 years, 9 months ago by sigurdm
Modified:
5 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix handling of lazy and and or in async functions. The two were interchanged. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44456

Patch Set 1 #

Patch Set 2 : Update unittest #

Total comments: 6

Patch Set 3 : Address Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -16 lines) Patch
M pkg/compiler/lib/src/js/rewrite_async.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/async_await_js_transform_test.dart View 1 4 chunks +14 lines, -14 lines 0 comments Download
A tests/language/async_and_or_test.dart View 1 2 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sigurdm
5 years, 9 months ago (2015-03-11 07:54:26 UTC) #2
sigurdm
PING!
5 years, 9 months ago (2015-03-13 08:40:39 UTC) #3
floitsch
LGTM. https://codereview.chromium.org/996103002/diff/20001/tests/language/async_and_or_test.dart File tests/language/async_and_or_test.dart (right): https://codereview.chromium.org/996103002/diff/20001/tests/language/async_and_or_test.dart#newcode37 tests/language/async_and_or_test.dart:37: Expect.isFalse(await confuse(traceA(false)) && await confuse(traceB(false))); long line. https://codereview.chromium.org/996103002/diff/20001/tests/language/async_and_or_test.dart#newcode54 ...
5 years, 9 months ago (2015-03-13 08:55:41 UTC) #4
sigurdm
Committed patchset #3 (id:40001) manually as 44456 (presubmit successful).
5 years, 9 months ago (2015-03-13 12:11:52 UTC) #5
sigurdm
5 years, 7 months ago (2015-05-08 07:44:52 UTC) #6
Message was sent while issue was closed. 
Forgot to post responses

https://codereview.chromium.org/996103002/diff/20001/tests/language/async_and...
File tests/language/async_and_or_test.dart (right):

https://codereview.chromium.org/996103002/diff/20001/tests/language/async_and...
tests/language/async_and_or_test.dart:37: Expect.isFalse(await
confuse(traceA(false)) && await confuse(traceB(false)));
On 2015/03/13 08:55:40, floitsch wrote:
> long line.

Done.

https://codereview.chromium.org/996103002/diff/20001/tests/language/async_and...
tests/language/async_and_or_test.dart:54: Expect.isFalse(await
confuse(traceA(false)) || await confuse(traceB(false)));
On 2015/03/13 08:55:40, floitsch wrote:
> long line.

Done.

https://codereview.chromium.org/996103002/diff/20001/tests/language/async_and...
tests/language/async_and_or_test.dart:84: confuse(x) {
On 2015/03/13 08:55:40, floitsch wrote:
> move this up.

Done.

Powered by Google App Engine
This is Rietveld 408576698