Issue 995883002: Yesterday's deadlock fix was wrong. It could drop notifications.

Issue 995883002: Yesterday's deadlock fix was wrong. It could drop notifications. (Closed)

Created:
5 years, 9 months ago by turnidge

Modified:
5 years, 9 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Yesterday's deadlock fix was wrong. It could drop notifications. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44382

Patch Set 2 : code review / fix type error #

Patch Set 3 : code review / type fix #

Patch Set 4 : #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -35 lines)			Patch
M	runtime/bin/dbg_message.cc	View		1 chunk	+2 lines, -8 lines	0 comments	Download
M	runtime/include/dart_api.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/debugger.dart	View	1 2	2 chunks	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/message_handler.cc	View		1 chunk	+26 lines, -24 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

https://codereview.chromium.org/995883002/diff/1/runtime/bin/dbg_message.cc File runtime/bin/dbg_message.cc (right): https://codereview.chromium.org/995883002/diff/1/runtime/bin/dbg_message.cc#newcode1102 runtime/bin/dbg_message.cc:1102: resume = Dart_HandleServiceMessages(); Maybe add a note in dart_api.h ...

5 years, 9 months ago (2015-03-10 16:07:28 UTC) #5

turnidge

5 years, 9 months ago (2015-03-10 18:15:48 UTC) #7

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 44382 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages