Issue 99583008: Add fallback-implementation for sendfile on linux and android.

Issue 99583008: Add fallback-implementation for sendfile on linux and android. (Closed)

Created:
7 years ago by Anders Johnsen

Modified:
7 years ago

Reviewers:
Søren Gjesse, Bill Hesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add fallback-implementation for sendfile on linux and android. BUG= Committed: https://code.google.com/p/dart/source/detail?r=31134

Patch Set 2 : Fix write bailout on writing too few bytes. #

Total comments: 6

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -8 lines)			Patch
	M	runtime/bin/file_android.cc	View	1	1 chunk	+16 lines, -4 lines	4 comments	Download
	M	runtime/bin/file_linux.cc	View	1	1 chunk	+16 lines, -4 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

lgtm https://codereview.chromium.org/99583008/diff/1/runtime/bin/file_android.cc File runtime/bin/file_android.cc (right): https://codereview.chromium.org/99583008/diff/1/runtime/bin/file_android.cc#newcode253 runtime/bin/file_android.cc:253: if (wrote != result) { LGTM, with result ...

7 years ago (2013-12-13 14:17:59 UTC) #3

Anders Johnsen

Committed patchset #2 manually as r31134 (presubmit successful).

7 years ago (2013-12-13 14:18:18 UTC) #4

Søren Gjesse

https://codereview.chromium.org/99583008/diff/20001/runtime/bin/file_android.cc File runtime/bin/file_android.cc (right): https://codereview.chromium.org/99583008/diff/20001/runtime/bin/file_android.cc#newcode246 runtime/bin/file_android.cc:246: } Please add a comment to this "feature testing". ...

7 years ago (2013-12-16 08:01:51 UTC) #5

Anders Johnsen

7 years ago (2013-12-16 08:52:56 UTC) #6

Message was sent while issue was closed.

See https://codereview.chromium.org/102663005

https://codereview.chromium.org/99583008/diff/20001/runtime/bin/file_android.cc
File runtime/bin/file_android.cc (right):

https://codereview.chromium.org/99583008/diff/20001/runtime/bin/file_android....
runtime/bin/file_android.cc:246: }
On 2013/12/16 08:01:52, Søren Gjesse wrote:
> Please add a comment to this "feature testing". Is it supported on some
Android
> versions?

Done.

https://codereview.chromium.org/99583008/diff/20001/runtime/bin/file_android....
runtime/bin/file_android.cc:248: const intptr_t kBufferSize = 8 * 1024;
On 2013/12/16 08:01:52, Søren Gjesse wrote:
> We actually have the constant KB in platform/globals.h.

Done.

https://codereview.chromium.org/99583008/diff/20001/runtime/bin/file_linux.cc
File runtime/bin/file_linux.cc (right):

https://codereview.chromium.org/99583008/diff/20001/runtime/bin/file_linux.cc...
runtime/bin/file_linux.cc:247: }
On 2013/12/16 08:01:52, Søren Gjesse wrote:
> So this is not Android only?

No, the actual failure that lead to this was on linux-arm.

Expand Messages | Collapse Messages