Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 995623002: Fix bugs where events could be added after watchers were closed. (Closed)

Created:
5 years, 9 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/watcher@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bugs where events could be added after watchers were closed. R=rnystrom@google.com BUG=dartbug.com/22653 Committed: https://github.com/dart-lang/watcher/commit/9cc5949664920be216996b1306216d61ebdda817

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/directory_watcher/linux.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/directory_watcher/mac_os.dart View 4 chunks +15 lines, -7 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/directory_watcher/shared.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 9 months ago (2015-03-09 23:17:28 UTC) #1
Bob Nystrom
LGTM. Tests pass fine on my mac.
5 years, 9 months ago (2015-03-10 17:05:48 UTC) #2
nweiz
5 years, 9 months ago (2015-03-10 19:47:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9cc5949664920be216996b1306216d61ebdda817 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698