Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 994853003: Fix dart2js for switches in async code with only awaits in the key. (Closed)

Created:
5 years, 9 months ago by sigurdm
Modified:
5 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix dart2js for switches in async code with only awaits in the key. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -1 line) Patch
M pkg/compiler/lib/src/js/rewrite_async.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js/async_await_js_transform_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download
M tests/language/async_switch_test.dart View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sigurdm
5 years, 9 months ago (2015-03-10 13:54:45 UTC) #2
floitsch
LGTM.
5 years, 9 months ago (2015-03-10 13:57:08 UTC) #3
sigurdm
5 years, 9 months ago (2015-03-10 14:25:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44371 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698