Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 99483006: Update the Linux watcher to accommodate changes in [Directory.watch]. (Closed)

Created:
7 years ago by nweiz
Modified:
7 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update the Linux watcher to accommodate changes in [Directory.watch]. This also removes the extra time allotted for the test since issue 14606 is now mitigated. R=rnystrom@google.com BUG=15446 Committed: https://code.google.com/p/dart/source/detail?r=30874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/watcher/lib/src/directory_watcher/linux.dart View 2 chunks +12 lines, -1 line 0 comments Download
M pkg/watcher/test/directory_watcher/linux_test.dart View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years ago (2013-12-04 21:00:50 UTC) #1
Bob Nystrom
LGTM!
7 years ago (2013-12-04 21:09:25 UTC) #2
nweiz
7 years ago (2013-12-04 22:31:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30874 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698