Issue 994823003: Use no arguments when simulating implicit call to super constructor during type inference.

Issue 994823003: Use no arguments when simulating implicit call to super constructor during type inference. (Closed)

Created:
5 years, 9 months ago by herhut

Modified:
5 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Use no arguments when simulating implicit call to super constructor during type inference. BUG= http://dartbug.com/22723 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44380

Patch Set 2 : comments #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -2 lines)			Patch
	M	pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart	View		2 chunks	+10 lines, -2 lines	0 comments	Download
	A	tests/language/implicit_super_constructor_call_test.dart	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/994823003/diff/1/tests/language/implicit_super_constructor_call_test.dart File tests/language/implicit_super_constructor_call_test.dart (right): https://codereview.chromium.org/994823003/diff/1/tests/language/implicit_super_constructor_call_test.dart#newcode1 tests/language/implicit_super_constructor_call_test.dart:1: // Copyright (c) 2014, the Dart project authors. ...

5 years, 9 months ago (2015-03-10 13:55:32 UTC) #2

herhut

Committed patchset #2 (id:20001) manually as 44380 (presubmit successful).

5 years, 9 months ago (2015-03-10 17:33:35 UTC) #3

herhut

5 years, 9 months ago (2015-03-11 14:18:01 UTC) #4

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/987393002/ has landed and I use
annotations now instead.

https://codereview.chromium.org/994823003/diff/1/tests/language/implicit_supe...
File tests/language/implicit_super_constructor_call_test.dart (right):

https://codereview.chromium.org/994823003/diff/1/tests/language/implicit_supe...
tests/language/implicit_super_constructor_call_test.dart:1: // Copyright (c)
2014, the Dart project authors.  Please see the AUTHORS file
On 2015/03/10 13:55:32, floitsch wrote:
> 2015

Done.

https://codereview.chromium.org/994823003/diff/1/tests/language/implicit_supe...
tests/language/implicit_super_constructor_call_test.dart:15: try {} catch (_)
{}; // Make sure it really does not get inlined.
On 2015/03/10 13:55:32, floitsch wrote:
> Use annotation instead.

Will do once https://chromiumcodereview.appspot.com/987393002/ lands.

https://codereview.chromium.org/994823003/diff/1/tests/language/implicit_supe...
tests/language/implicit_super_constructor_call_test.dart:25:
Expect.equals(c.x.toString(), "foo");
On 2015/03/10 13:55:32, floitsch wrote:
> expected is first.

Done.

Expand Messages | Collapse Messages