Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 99463005: Update stream iterator doc and add test. (Closed)

Created:
7 years ago by Lasse Reichstein Nielsen
Modified:
7 years ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update test nam #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -2 lines) Patch
M sdk/lib/async/stream.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/async/stream_impl.dart View 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/async/stream_iterator_test.dart View 1 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
7 years ago (2013-12-19 15:19:49 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/99463005/diff/1/tests/lib/async/stream_iterator_test.dart File tests/lib/async/stream_iterator_test.dart (right): https://codereview.chromium.org/99463005/diff/1/tests/lib/async/stream_iterator_test.dart#newcode71 tests/lib/async/stream_iterator_test.dart:71: test("stream iterator read badly", () { Why is ...
7 years ago (2013-12-19 15:28:35 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/99463005/diff/1/tests/lib/async/stream_iterator_test.dart File tests/lib/async/stream_iterator_test.dart (right): https://codereview.chromium.org/99463005/diff/1/tests/lib/async/stream_iterator_test.dart#newcode71 tests/lib/async/stream_iterator_test.dart:71: test("stream iterator read badly", () { Short for "read ...
7 years ago (2013-12-19 15:30:17 UTC) #3
Lasse Reichstein Nielsen
7 years ago (2013-12-20 07:14:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r31317 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698