Issue 994323002: Support static getters and setters in the new dart2js code generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 994323002: Support static getters and setters in the new dart2js code generator. (Closed)

Created:
5 years, 9 months ago by Kevin Millikin (Google)

Modified:
5 years, 9 months ago

Reviewers:
karlklose, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Support static getters and setters in the new dart2js code generator. Implicit getters and setters are translated as field accesses, real getters and setters are translated as static function invocations. R=karlklose@google.com, sra@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44399

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -9 lines)			Patch
M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View	1 chunk	+20 lines, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/glue.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_basic_test.dart	View	1 chunk	+46 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Kevin Millikin (Google)

5 years, 9 months ago (2015-03-11 12:06:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44399 (presubmit successful).