Task: Build Library Element Model

Task: Build Library Element Model

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=44406

[Brian Wilkerson, 2015-03-11 14:16:01]

LGTM

https://codereview.chromium.org/994293002/diff/20001/pkg/analyzer/lib/src/tas...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/994293002/diff/20001/pkg/analyzer/lib/src/tas...
pkg/analyzer/lib/src/task/dart.dart:96: * defining compiltion unit of a library.
"compiltion" --> "compilation"

https://codereview.chromium.org/994293002/diff/20001/pkg/analyzer/lib/src/tas...
pkg/analyzer/lib/src/task/dart.dart:109: static String ENTRY_POINT_NAME =
"main";
Perhaps this should be moved to FunctionElement so that there's one common
(public) place to access it.

Also, why not 'const'?

https://codereview.chromium.org/994293002/diff/20001/pkg/analyzer/lib/src/tas...
pkg/analyzer/lib/src/task/dart.dart:313: setter.variable = variable;
I think we need to remove the setter's previous variable from the setter's
compilation unit.

Perhaps we should change BuildCompilationUnitElementTask so that it doesn't
create synthetic variables for setters in the first place so that we don't have
to clean-up here (although I expect this case to be rare).

https://codereview.chromium.org/994293002/diff/20001/pkg/analyzer/lib/task/da...
File pkg/analyzer/lib/task/dart.dart (right):

https://codereview.chromium.org/994293002/diff/20001/pkg/analyzer/lib/task/da...
pkg/analyzer/lib/task/dart.dart:69: * A flag specifying if a library imports
'dart:html'.
"if" --> "whether" (here and below)

[scheglov, 2015-03-11 16:55:07]

https://codereview.chromium.org/994293002/diff/20001/pkg/analyzer/lib/src/tas...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/994293002/diff/20001/pkg/analyzer/lib/src/tas...
pkg/analyzer/lib/src/task/dart.dart:96: * defining compiltion unit of a library.
On 2015/03/11 14:16:01, Brian Wilkerson wrote:
> "compiltion" --> "compilation"

Done.

https://codereview.chromium.org/994293002/diff/20001/pkg/analyzer/lib/src/tas...
pkg/analyzer/lib/src/task/dart.dart:109: static String ENTRY_POINT_NAME =
"main";
On 2015/03/11 14:16:01, Brian Wilkerson wrote:
> Perhaps this should be moved to FunctionElement so that there's one common
> (public) place to access it.
> 
> Also, why not 'const'?

Will do in the next CL.

https://codereview.chromium.org/994293002/diff/20001/pkg/analyzer/lib/src/tas...
pkg/analyzer/lib/src/task/dart.dart:313: setter.variable = variable;
On 2015/03/11 14:16:01, Brian Wilkerson wrote:
> I think we need to remove the setter's previous variable from the setter's
> compilation unit.
> 
> Perhaps we should change BuildCompilationUnitElementTask so that it doesn't
> create synthetic variables for setters in the first place so that we don't
have
> to clean-up here (although I expect this case to be rare).

Done.

https://codereview.chromium.org/994293002/diff/20001/pkg/analyzer/lib/task/da...
File pkg/analyzer/lib/task/dart.dart (right):

https://codereview.chromium.org/994293002/diff/20001/pkg/analyzer/lib/task/da...
pkg/analyzer/lib/task/dart.dart:69: * A flag specifying if a library imports
'dart:html'.
On 2015/03/11 14:16:01, Brian Wilkerson wrote:
> "if" --> "whether" (here and below)

Done.

[scheglov, 2015-03-11 16:57:24]

Committed patchset #3 (id:40001) manually as 44406 (presubmit successful).