Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 994253002: Add an analyzer option to properly check ".call" methods. (Closed)

Created:
5 years, 9 months ago by Paul Berry
Modified:
5 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an analyzer option to properly check ".call" methods. Enabling this option fixes issue 21938. For now the option is disabled by default, since there is a lot of code in the dart SDK (and in third_party) that isn't warning clean with this option enabled. Once the SDK and third_party code have been cleaned up, we should be able to turn this option on permanently. BUG=dartbug.com/21938 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -8 lines) Patch
M pkg/analysis_server/lib/src/get_handler.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/options.dart View 3 chunks +12 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/analyzer_impl.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 5 chunks +15 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 5 chunks +16 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 5 chunks +89 lines, -0 lines 0 comments Download
M pkg/analyzer/test/options_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 9 months ago (2015-03-11 00:18:10 UTC) #2
scheglov
LGTM
5 years, 9 months ago (2015-03-11 00:22:31 UTC) #3
Paul Berry
5 years, 9 months ago (2015-03-11 00:35:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44390 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698