Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 994103002: Make sure the mixin class is finalized immediately (and not some time later) (Closed)

Created:
5 years, 9 months ago by regis
Modified:
5 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make sure the mixin class is finalized immediately (and not some time later) before applying mixin members (issue 22719). Add regression test. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44383

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M runtime/vm/class_finalizer.cc View 1 chunk +1 line, -2 lines 0 comments Download
A tests/language/regress_22719_test.dart View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
This does not address the fact that EnsureIsFinalized() does not immediately finalize the class. If ...
5 years, 9 months ago (2015-03-10 18:23:58 UTC) #2
siva
lgtm I sent you a similar change list, you can ignore my CL :-) https://codereview.chromium.org/994103002/diff/1/tests/language/regress_22719_test.dart ...
5 years, 9 months ago (2015-03-10 18:31:34 UTC) #3
regis
Thanks! https://codereview.chromium.org/994103002/diff/1/tests/language/regress_22719_test.dart File tests/language/regress_22719_test.dart (right): https://codereview.chromium.org/994103002/diff/1/tests/language/regress_22719_test.dart#newcode25 tests/language/regress_22719_test.dart:25: print(i); On 2015/03/10 18:31:34, siva wrote: > Change ...
5 years, 9 months ago (2015-03-10 18:39:17 UTC) #4
regis
5 years, 9 months ago (2015-03-10 18:39:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r44383 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698