Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 994013002: Give test more time. (Closed)

Created:
5 years, 9 months ago by floitsch
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Give test more time. If a program is really slow, there might be some time before the next line is executed. Apparently 1s is not enough. In theory setTimeouts are supposed to be executed in the right order: https://html.spec.whatwg.org/multipage/webappapis.html#dom-windowtimers-settimeout Committed: https://code.google.com/p/dart/source/detail?r=44372

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/lib/async/timer_isActive_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
floitsch
TBR. (see http://build.chromium.org/p/client.dart/builders/dart2js-chrome-mac10.9-be/builds/68/steps/dart2js-chrome%20tests%20--dart2js-batch%20failures/logs/stdio for a failure)
5 years, 9 months ago (2015-03-10 14:48:23 UTC) #2
floitsch
5 years, 9 months ago (2015-03-10 14:48:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44372 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698