Recover gracefully if a matching port is unavailable.

Recover gracefully if a matching port is unavailable.

R=rnystrom@google.com
BUG=dartbug.com/22673

Committed: https://github.com/dart-lang/http_multi_server/commit/1988391c5ca63571171886a27f4c60044930c87a

[Bob Nystrom, 2015-03-09 22:02:55]

LGTM! Don't forget to tag and publish.

[nweiz, 2015-03-09 22:03:29]

Committed patchset #1 (id:1) manually as
1988391c5ca63571171886a27f4c60044930c87a (presubmit successful).

[skybrian, 2015-03-09 22:34:56]

skybrian@google.com changed reviewers:
+ skybrian@google.com

[skybrian, 2015-03-09 22:34:57]

https://codereview.chromium.org/993743002/diff/1/lib/http_multi_server.dart
File lib/http_multi_server.dart (right):

https://codereview.chromium.org/993743002/diff/1/lib/http_multi_server.dart#n...
lib/http_multi_server.dart:155: return _loopback(port, bind);
Retrying forever will cause the program to spin when something has gone terribly
wrong and ports are *really* scarce. I don't think this is too likely in
practice, but a general rule of thumb with network programming is that it's
better to exit with an error after a few retries, to avoid making severe
congestion worse.

(Or possibly back off by waiting increasingly longer before retrying, but that
seems overly fancy and would result in mysterious delays rather than a clear
error.)

[nweiz, 2015-03-09 23:38:15]

https://codereview.chromium.org/993743002/diff/1/lib/http_multi_server.dart
File lib/http_multi_server.dart (right):

https://codereview.chromium.org/993743002/diff/1/lib/http_multi_server.dart#n...
lib/http_multi_server.dart:155: return _loopback(port, bind);
On 2015/03/09 22:34:57, skybrian wrote:
> Retrying forever will cause the program to spin when something has gone
terribly
> wrong and ports are *really* scarce. I don't think this is too likely in
> practice, but a general rule of thumb with network programming is that it's
> better to exit with an error after a few retries, to avoid making severe
> congestion worse.
> 
> (Or possibly back off by waiting increasingly longer before retrying, but that
> seems overly fancy and would result in mysterious delays rather than a clear
> error.)

https://codereview.chromium.org/992843002/