Mark native functions when they are created.

Mark native functions when they are created.

Until now the parser marked native functions as native when parsing.

This may be too late for some functions. E.g. the native typed list
constructor may not be invoked because the intrinsic code is executed
instead (unless for example new-space allocation fails).

This causes missing type information when optimizing functions using
those recognized factory functions like Uint8List._new.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30846

[srdjan, 2013-12-02 18:32:34]

LGTM. 

The Function::New has become almost unreadable as it has too many arguments. I
like having to set native flag at construction time, not explicitly via a call.
Any idea how to make the function factories simpler?

[Florian Schneider, 2013-12-04 10:32:56]

Committed patchset #2 manually as r30846 (presubmit successful).

[Florian Schneider, 2013-12-04 10:35:18]

On 2013/12/02 18:32:34, srdjan wrote:
> LGTM. 
> 
> The Function::New has become almost unreadable as it has too many arguments. I
> like having to set native flag at construction time, not explicitly via a
call.
> Any idea how to make the function factories simpler?

It is pretty complicated. The alternative (not passing a constructor argument)
is not ideal either. It is too easy to forget to set the flags correctly after
construction.

Maybe multiple factory methods like NewNativeFunction, NewStaticFunction, etc.
would be better? What do you think?