Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 993673002: append html imports before the dart script tag (Closed)

Created:
5 years, 9 months ago by jakemac
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-components.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : add some js script tags to the head around the dart script tag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -4 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/build/web_components.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/build/transformer_test.dart View 1 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jakemac
5 years, 9 months ago (2015-03-09 19:54:17 UTC) #2
Siggi Cherem (dart-lang)
nice! https://codereview.chromium.org/993673002/diff/1/test/build/transformer_test.dart File test/build/transformer_test.dart (right): https://codereview.chromium.org/993673002/diff/1/test/build/transformer_test.dart#newcode127 test/build/transformer_test.dart:127: <script type="application/dart" src="index.dart"></script> let's add some <!-- nodes ...
5 years, 9 months ago (2015-03-09 21:04:53 UTC) #3
jakemac
https://codereview.chromium.org/993673002/diff/1/test/build/transformer_test.dart File test/build/transformer_test.dart (right): https://codereview.chromium.org/993673002/diff/1/test/build/transformer_test.dart#newcode127 test/build/transformer_test.dart:127: <script type="application/dart" src="index.dart"></script> On 2015/03/09 21:04:53, Siggi Cherem (dart-lang) ...
5 years, 9 months ago (2015-03-09 21:55:11 UTC) #4
Siggi Cherem (dart-lang)
lgtm, thanks!
5 years, 9 months ago (2015-03-09 21:59:05 UTC) #5
jakemac
5 years, 9 months ago (2015-03-10 16:09:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b2e2f2956f28f0741b5f797d4d78b9f1cb55d419 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698