Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 993573002: Ensure that collectedClasses always contains a [globalObject, descriptor] pair. (Closed)

Created:
5 years, 9 months ago by herhut
Modified:
5 years, 9 months ago
Reviewers:
zarah
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Ensure that collectedClasses always contains a [globalObject, descriptor] pair. BUG= R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=44322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/dart2js_incremental/lib/library_updater.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
herhut
5 years, 9 months ago (2015-03-09 15:07:09 UTC) #2
zarah
LGTM
5 years, 9 months ago (2015-03-09 15:10:22 UTC) #3
herhut
5 years, 9 months ago (2015-03-09 15:14:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44322 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698