Issue 99303004: Remove unused API.

Issue 99303004: Remove unused API. (Closed)

Created:
7 years ago by ahe

Modified:
7 years ago

Reviewers:
Johnni Winther, polux, ngeoffray

CC:
reviews_dartlang.org, ngeoffray, polux

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove unused API. R=johnniwinther@google.com, polux@google.com Committed: https://code.google.com/p/dart/source/detail?r=30853

Patch Set 2 : Address review comments #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+233 lines, -527 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/closure.dart	View		3 chunks	+0 lines, -30 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/code_buffer.dart	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/compiler.dart	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/constant_system.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/constant_system_dart.dart	View		10 chunks	+0 lines, -13 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/constants.dart	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart	View		2 chunks	+0 lines, -12 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View		3 chunks	+0 lines, -25 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/elements/visitor.dart	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js/builder.dart	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js/nodes.dart	View		2 chunks	+0 lines, -10 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart	View		5 chunks	+0 lines, -5 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View		3 chunks	+0 lines, -12 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/native_handler.dart	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		4 chunks	+0 lines, -29 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/resolution/scope.dart	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/keyword.dart	View		3 chunks	+0 lines, -5 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/parser.dart	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		3 chunks	+0 lines, -17 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	2 chunks	+0 lines, -9 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	1	10 chunks	+0 lines, -77 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/string_validator.dart	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/tree/nodes.dart	View	1	5 chunks	+2 lines, -7 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/typechecker.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart	View	1	6 chunks	+0 lines, -47 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart	View		3 chunks	+0 lines, -32 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/types/forwarding_type_mask.dart	View		3 chunks	+0 lines, -12 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/types/type_mask.dart	View		3 chunks	+0 lines, -11 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/types/types.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/types/union_type_mask.dart	View		2 chunks	+0 lines, -13 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/universe/side_effects.dart	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/universe/universe.dart	View		2 chunks	+0 lines, -9 lines	0 comments	Download
A	dart/sdk/lib/_internal/compiler/implementation/use_unused_api.dart	View	1	1 chunk	+188 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/world.dart	View	1	5 chunks	+0 lines, -31 lines	0 comments	Download
M	dart/tests/compiler/dart2js/analyze_dart2js_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js/analyze_helper.dart	View		1 chunk	+16 lines, -7 lines	0 comments	Download
A	dart/tests/compiler/dart2js/analyze_unused_dart2js_test.dart	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	dart/tests/compiler/dart2js/exit_code_test.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/99303004/diff/20001/dart/sdk/lib/_internal/compiler/implementation/code_buffer.dart File dart/sdk/lib/_internal/compiler/implementation/code_buffer.dart (left): https://codereview.chromium.org/99303004/diff/20001/dart/sdk/lib/_internal/compiler/implementation/code_buffer.dart#oldcode55 dart/sdk/lib/_internal/compiler/implementation/code_buffer.dart:55: CodeBuffer writeln([var object = ""]) { This implements ...

7 years ago (2013-12-03 11:52:30 UTC) #2

ngeoffray

https://codereview.chromium.org/99303004/diff/20001/dart/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart File dart/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (left): https://codereview.chromium.org/99303004/diff/20001/dart/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#oldcode410 dart/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:410: /** On 2013/12/03 11:52:31, Johnni Winther wrote: > Run ...

7 years ago (2013-12-04 09:59:00 UTC) #3

polux

lgtm https://codereview.chromium.org/99303004/diff/20001/dart/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart File dart/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (left): https://codereview.chromium.org/99303004/diff/20001/dart/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#oldcode410 dart/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:410: /** On 2013/12/04 09:59:01, ngeoffray wrote: > On ...

7 years ago (2013-12-04 10:12:44 UTC) #4

ahe

Thank you, Nicolas, Johnni, and Paul! https://codereview.chromium.org/99303004/diff/20001/dart/sdk/lib/_internal/compiler/implementation/code_buffer.dart File dart/sdk/lib/_internal/compiler/implementation/code_buffer.dart (left): https://codereview.chromium.org/99303004/diff/20001/dart/sdk/lib/_internal/compiler/implementation/code_buffer.dart#oldcode55 dart/sdk/lib/_internal/compiler/implementation/code_buffer.dart:55: CodeBuffer writeln([var object ...

7 years ago (2013-12-04 11:45:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r30853 (presubmit successful).

Expand Messages | Collapse Messages