Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 991373003: Allow await in assert (fix issue 22728). (Closed)

Created:
5 years, 9 months ago by regis
Modified:
5 years, 9 months ago
Reviewers:
hausner, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Allow await in assert (fix issue 22728). Add regression test. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M runtime/vm/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
A tests/language/regress_22728_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
5 years, 9 months ago (2015-03-10 20:36:48 UTC) #2
Ivan Posva
LGTM -ip
5 years, 9 months ago (2015-03-10 22:30:00 UTC) #4
regis
5 years, 9 months ago (2015-03-10 22:44:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r44388 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698