Issue 991033002: Fix type promotion (issue 22732)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 991033002: Fix type promotion (issue 22732) (Closed)

Created:
5 years, 9 months ago by Brian Wilkerson

Modified:
5 years, 9 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -0 lines)			Patch
	M	pkg/analyzer/lib/src/generated/resolver.dart	View		1 chunk	+11 lines, -0 lines	0 comments	Download
	M	pkg/analyzer/test/generated/resolver_test.dart	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Brian Wilkerson

I don't want to commit this until the bots are green again, but I think ...

5 years, 9 months ago (2015-03-09 21:09:42 UTC) #2

Paul Berry

lgtm, however I'd suggest un-doing https://code.google.com/p/dart/source/detail?r=44333 as part of this CL, for further reassurance that ...

5 years, 9 months ago (2015-03-09 22:43:25 UTC) #3

Brian Wilkerson

5 years, 9 months ago (2015-03-11 18:01:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44410 (presubmit successful).