Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 990363002: Suspend after async generator terminates (Closed)

Created:
5 years, 9 months ago by hausner
Modified:
5 years, 9 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Suspend after async generator terminates Suspend the async generator after it closes the stream. If there are outstanding requests to schedule the generator, this ensures that no portions of the generator body get executed again. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=44352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M runtime/vm/parser.cc View 2 chunks +12 lines, -6 lines 0 comments Download
M tests/language/async_throw_in_catch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 9 months ago (2015-03-09 22:54:15 UTC) #2
regis
LGTM
5 years, 9 months ago (2015-03-09 23:16:38 UTC) #3
hausner
5 years, 9 months ago (2015-03-09 23:25:09 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as r44352 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698